Removed 'enable powerups' from the default.cfg#24
Open
tcsabina wants to merge 2 commits intonQuake:masterfrom
Open
Removed 'enable powerups' from the default.cfg#24tcsabina wants to merge 2 commits intonQuake:masterfrom
tcsabina wants to merge 2 commits intonQuake:masterfrom
Conversation
Contributor
|
Some of the modes assume that it's in the main default.cfg, like 4on4 etc, so it'd have to be added to all those. |
Collaborator
|
Yeah it looks like these modes don't specify k_pow at all: so I guess they would default to the top-level default.cfg, so changing k_pow there would have an unintended impact on all these modes. and ctf and matchless also don't have k_pow but have k_pow_min_players and k_pow_check_time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to solve QW-Group/ktx#284.
I think this is the cleanest and easiest solution, to solve the 'powerups enabled in hooneymode' issue. I don't think there is a usermode (2on2, 4on4, etc) that need powerups and does not have 'k_pow 1' in its corresponding default.cfg, so removing this from the top-level default.cfg would do no harm.